Add SLH-DSA Support - #455
Open
aidangarske wants to merge 22 commits into
Open
Conversation
aidangarske
force-pushed
the
add-slhdsa
branch
2 times, most recently
from
July 30, 2026 18:27
0487400 to
02cbe8b
Compare
aidangarske
added
ci:libacvp-pqc
aidangarske
added
ci:libacvp-pqc
aidangarske
marked this pull request as ready for review
July 30, 2026 23:26
aidangarske
force-pushed
the
add-slhdsa
branch
2 times, most recently
from
July 31, 2026 01:05
8bf2ba2 to
ba88c76
Compare
aidangarske
added
ci:libacvp-pqc
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
aidangarske
added
ci:libacvp-pqc
Signed-off-by: Aidan Garske <aidan@wolfssl.com>
aidangarske
added
ci:libacvp-pqc
Frauschi
requested changes
Aug 6, 2026
Frauschi
left a comment
Frauschi
left a comment
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: REQUEST_CHANGES
Findings: 12 total — 5 posted, 7 skipped
Posted findings
- [High] openssl_example.c rewrite hard-fails on the IDE/Android and IDE/XCODE flows —
examples/openssl_example.c:47-75 (duplicated in examples/pqc_openssl_example.c:225-238) - [Medium] KAT vector accounting: the verify-only SLH-DSA KAT can pass with zero vectors, the exact 3099 count is pinned against a floating OpenSSL tag, and the old 2602 comment was left behind —
.github/workflows/wolfssl-versions-pqc.yml:204-214 - [Medium] WOLFSSL_SLHDSA_CONFIG is missing from the dependency cache key, undocumented in --help, and contradicted by INTEGRATION_GUIDE —
scripts/utils-wolfssl.sh:64-70 - [Medium] Example build gating and portability: executableDir may trip -Wmaybe-uninitialized, and BUILD_PQC_EXAMPLE is true for verify-only SLH-DSA builds where the example always fails —
examples/openssl_example.c:62-75; examples/pqc_openssl_example.c:225-238 - [Low] wp_mlkem_kem.c doc comment no longer matches the code it documents —
src/wp_mlkem_kem.c:186
Skipped findings
- [High] libacvp PQC job likely cannot build runtest, so the whole workflow may no-op
- [Medium] SLH-DSA test coverage gaps: four guard paths and the deterministic-keygen seed length validation are unexercised
- [Low] CI workflow hygiene: example steps run before the dependency push, nginx-pqc adds per-workflow apt installs, and test.sh defaults WOLFPROV_ROOT to a path nothing produces
- [Low] wp_slhdsa_key_types uses opaque index arithmetic into a flat parameter array
- [Low] test_slhdsa.c hygiene: randomised input described as deterministic, a verify context initialised with sign-only params, mixed XMEM*/libc string calls, and redundant double cleanup
- [Low] SLH-DSA locking contract is looser than the mutex implies: the key mutex is held across the full multi-second sign and across thread-local CheckKey work, wp_slhdsa_get_key() hands out a raw pointer to guarded state, and construction-time hasPub/hasPriv writes are unlocked
- [Info] settings.h pulls a wolfSSL algorithm header into every translation unit
Review generated by Skoll via Claude/Codex
Frauschi
reviewed
Aug 7, 2026
Frauschi
left a comment
Frauschi
left a comment
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: APPROVE
Findings: 16 total — 7 posted, 9 skipped
Posted findings
- [Medium] SLH-DSA verify-only CI row is indistinguishable from the plain slhdsa row and cannot detect a lost WOLFSSL_SLHDSA_CONFIG —
.github/workflows/wolfssl-versions-pqc.yml:183-191 - [Medium] wc_SlhDsaKey_CheckKey runs twice on every SLH-DSA keypair import —
src/wp_slhdsa_kmgmt.c:854,895 - [Low] wp_slhdsa_validate holds keyMutex across a full key copy and wc_SlhDsaKey_CheckKey —
src/wp_slhdsa_kmgmt.c:745-795 - [Low] nginx-pqc installs packages that are already baked into the test-deps image, against that image's stated policy —
.github/workflows/nginx-pqc.yml:132-136 - [Low] Missing cast on OPENSSL_malloc return —
src/wp_slhdsa_kmgmt.c:766 - [Low]
if (dupPub)is not guarded byokwhile the adjacentif (ok && dupPriv)is —src/wp_slhdsa_kmgmt.c:455 - [Low]
word32 sigSz;declared uninitialized in wp_slhdsa_sign —src/wp_slhdsa_sig.c:344
Skipped findings
- [Low] run_vector_family silently mutates its caller's
localcounters via bash dynamic scoping - [Low] 7 of 12 SLH-DSA AlgorithmIdentifier OID arcs are never exercised by any test
- [Low] extra_key gains a stray trailing dash on 7 of 8 matrix rows
- [Low] wp_slhdsa_validate nests refMutex inside keyMutex and runs the full CheckKey inside the shared key's critical section
- [Low] wp_slhdsa_sign and wp_slhdsa_verify hold the per-key mutex across the entire multi-second wolfSSL SLH-DSA operation
- [Info] Do not 'fix' SLH-DSA's export_object / verify_message_final to match ML-DSA and ECX -- SLH-DSA is the correct one
- [Info] Examples gate on the configure macro WOLFPROV_HAVE_* rather than the resolved WP_HAVE_*
- [Info] encData cleansed with post-encryption length instead of allocation size
- [Info] Three sites write hasPub/hasPriv without keyMutex, contradicting the invariant documented at wp_slhdsa_kmgmt.c:271
Review generated by Skoll via Claude/Codex
aidangarske
requested review from
wolfSSL-Fenrir-bot
and
a balanced review from Copilot
August 7, 2026 19:34
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated no new comments.
Suppressed comments (1)
docs/INTEGRATION_GUIDE.md:171
- The updated PQC requirements still say that any OpenSSL 3.x is supported on the next line, but
settings.hgates ML-KEM, ML-DSA, and SLH-DSA on OpenSSL 3.6+. Following this guide with OpenSSL 3.0–3.5 therefore ends in a compile-time error. Update the OpenSSL requirement to 3.6+.
- **wolfSSL**: v5.9.2-stable or later. v5.9.1-stable defines `HAVE_DILITHIUM` and exposes `wc_dilithium_sign_ctx_msg` (the older name for the FIPS 204 pure-mode signer) but does not yet ship the canonical `WOLFSSL_HAVE_MLDSA` macro, `<wolfssl/wolfcrypt/wc_mldsa.h>` header, or `wc_MlDsaKey_SignCtx` alias that wolfProvider gates on.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #455
Scan targets checked: wolfprovider-bugs, wolfprovider-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
aidangarske
added
ci:libacvp-pqc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description